rebels.cpp

Go to the documentation of this file.

#include "rebels.hpp"
#include "system_state.hpp"
#include "triggers.hpp"
#include "ai.hpp"
#include "effects.hpp"
#include "demographics.hpp"
#include "gui_event.hpp"
#include "politics.hpp"
#include "province_templates.hpp"
#include "prng.hpp"
 
namespace rebel {
 
dcon::movement_id get_movement_by_position(sys::state& state, dcon::nation_id n, dcon::issue_option_id o) {
    for(auto m : state.world.nation_get_movement_within(n)) {
        if(m.get_movement().get_associated_issue_option() == o)
            return m.get_movement().id;
    }
    return dcon::movement_id{};
}
dcon::movement_id get_movement_by_independence(sys::state& state, dcon::nation_id n, dcon::national_identity_id i) {
    for(auto m : state.world.nation_get_movement_within(n)) {
        if(m.get_movement().get_associated_independence() == i)
            return m.get_movement().id;
    }
    return dcon::movement_id{};
}
 
dcon::rebel_faction_id get_faction_by_type(sys::state& state, dcon::nation_id n, dcon::rebel_type_id r) {
    for(auto f : state.world.nation_get_rebellion_within(n)) {
        if(f.get_rebels().get_type() == r)
            return f.get_rebels().id;
    }
    return dcon::rebel_faction_id{};
}
 
void update_movement_values(sys::state& state) { // simply updates cached values
 
    state.world.execute_serial_over_movement([&](auto ids) { state.world.movement_set_pop_support(ids, ve::fp_vector()); });
    state.world.for_each_pop([&](dcon::pop_id p) {
        if(auto m = state.world.pop_get_movement_from_pop_movement_membership(p); m) {
            auto i = state.world.movement_get_associated_issue_option(m);
            state.world.movement_get_pop_support(m) += state.world.pop_get_size(p) * (i ? pop_demographics::get_demo(state, p, pop_demographics::to_key(state, i)) : 1.0f);
        }
    });
 
    static ve::vectorizable_buffer<float, dcon::nation_id> nation_reform_count(uint32_t(1));
    static uint32_t old_count = 1;
 
    auto new_count = state.world.nation_size();
    if(new_count > old_count) {
        nation_reform_count = state.world.nation_make_vectorizable_float_buffer();
        old_count = new_count;
    }
 
    state.world.execute_serial_over_nation([&](auto host_nations) {
        nation_reform_count.set(host_nations, 0.0f);
    });
 
    for(auto preform : state.culture_definitions.political_issues) {
        if(state.world.issue_get_is_next_step_only(preform)) {
            auto base_reform = state.world.issue_get_options(preform)[0].index() + 1;
 
            state.world.execute_serial_over_nation([&](auto host_nations) {
                ve::fp_vector reform_totals = nation_reform_count.get(host_nations);
                ve::tagged_vector<dcon::issue_option_id> creform = state.world.nation_get_issues(host_nations, preform);
                reform_totals = reform_totals + ve::to_float(ve::int_vector(creform.to_original_values()) - base_reform);
                nation_reform_count.set(host_nations, reform_totals);
            });
        }
    }
 
    state.world.execute_serial_over_movement([&](auto ids) {
        /*
        - Movements can accumulate radicalism, but only in civ nations. Internally we may represent radicalism as two values, a
        radicalism value and transient radicalism. Every day the radicalism value is computed as: define:MOVEMENT_RADICALISM_BASE
        + the movements current transient radicalism + number-of-political-reforms-passed-in-the-country-over-base x
        define:MOVEMENT_RADICALISM_PASSED_REFORM_EFFECT + radicalism-of-the-nation's-primary-culture +
        maximum-nationalism-value-in-any-province x define:MOVEMENT_RADICALISM_NATIONALISM_FACTOR +
        define:POPULATION_MOVEMENT_RADICAL_FACTOR x movement-support / nation's-non-colonial-population.
        */
        auto host_nations = state.world.movement_get_nation_from_movement_within(ids);
 
        auto host_max_nationalism = ve::apply(
                [&](dcon::nation_id n, dcon::movement_id m) {
                    if(auto iid = state.world.movement_get_associated_independence(m); iid) {
                        float nmax = 0.0f;
                        for(auto c : state.world.national_identity_get_core(iid)) {
                            if(c.get_province().get_nation_from_province_ownership() == n) {
                                nmax = std::max(nmax, c.get_province().get_nationalism());
                            }
                        }
                        return nmax;
                    } else {
                        return 0.0f;
                    }
                },
                host_nations, ids);
        auto host_pculture = state.world.nation_get_primary_culture(host_nations);
        auto host_cradicalism = ve::to_float(state.world.culture_get_radicalism(host_pculture));
 
        auto ref_effect = nation_reform_count.get(host_nations) * state.defines.movement_radicalism_passed_reform_effect;
        auto nat_effect = host_max_nationalism * state.defines.movement_radicalism_nationalism_factor;
        auto mov_support = state.world.movement_get_pop_support(ids);
        auto non_c_pop = state.world.nation_get_non_colonial_population(host_nations);
        auto support_effect = state.defines.population_movement_radical_factor * mov_support / non_c_pop;
 
        auto new_radicalism = state.world.movement_get_transient_radicalism(ids) + state.defines.movement_radicalism_base
            + ref_effect + host_cradicalism + nat_effect + support_effect;
        state.world.movement_set_radicalism(ids, ve::max(0.0f, new_radicalism));
    });
}
 
void add_pop_to_movement(sys::state& state, dcon::pop_id p, dcon::movement_id m) {
    remove_pop_from_movement(state, p);
    auto i = state.world.movement_get_associated_issue_option(m);
    state.world.movement_get_pop_support(m) += state.world.pop_get_size(p) * (i ? pop_demographics::get_demo(state, p, pop_demographics::to_key(state, i)) : 1.0f);
    state.world.try_create_pop_movement_membership(p, m);
}
void remove_pop_from_movement(sys::state& state, dcon::pop_id p) {
    auto prior_movement = state.world.pop_get_movement_from_pop_movement_membership(p);
    if(prior_movement) {
        auto i = state.world.movement_get_associated_issue_option(prior_movement);
        state.world.movement_get_pop_support(prior_movement) -= state.world.pop_get_size(p) * (i ? pop_demographics::get_demo(state, p, pop_demographics::to_key(state, i)) : 1.0f);
        state.world.delete_pop_movement_membership(state.world.pop_get_pop_movement_membership(p));
    }
}
 
void suppress_movement(sys::state& state, dcon::nation_id n, dcon::movement_id m) {
    /*
    - When a movement is suppressed:
    Increase the transient radicalism of the movement by: define:SUPPRESSION_RADICALISM_HIT
    Set the consciousness of all pops that were in the movement to 1 and remove them from it.
    */
    state.world.movement_get_transient_radicalism(m) += state.defines.suppression_radicalisation_hit;
    for(auto p : state.world.movement_get_pop_movement_membership(m)) {
        //auto old_con = pop_demographics::get_consciousness(state, p.get_pop());
        pop_demographics::set_consciousness(state, p.get_pop().id, 1.0f);
    }
    state.world.movement_remove_all_pop_movement_membership(m);
}
 
void turn_movement_into_rebels(sys::state& state, dcon::movement_id m) {
    /*
    - When the radicalism value for a movement reaches 100, pops get removed from the movement and added to a rebel faction. Those
    pops have their militancy increased to a minimum of define:MIL_ON_REB_MOVE. See below for determining which rebel faction the
    pop joins.
    */
 
    for(auto p : state.world.movement_get_pop_movement_membership(m)) {
        pop_demographics::set_militancy(state, p.get_pop().id, std::max(pop_demographics::get_militancy(state, p.get_pop()), state.defines.mil_on_reb_move));
    }
    // and then they will automatically be picked up by updating rebels
 
    state.world.delete_movement(m);
}
 
bool issue_is_valid_for_movement(sys::state& state, dcon::nation_id nation_within, dcon::issue_option_id i) {
    auto parent_issue = state.world.issue_option_get_parent_issue(i);
    auto current_setting = state.world.nation_get_issues(nation_within, parent_issue);
    if(i == current_setting)
        return false;
    if(state.world.issue_get_is_next_step_only(parent_issue)) {
        if(i.index() != current_setting.id.index() - 1 && i.index() != current_setting.id.index() + 1)
            return false;
    }
    auto allow = state.world.issue_option_get_allow(i);
    if(allow && !trigger::evaluate(state, allow, trigger::to_generic(nation_within), trigger::to_generic(nation_within), 0))
        return false;
 
    return true;
}
 
bool movement_is_valid(sys::state& state, dcon::movement_id m) {
    auto i = state.world.movement_get_associated_issue_option(m);
 
    auto nation_within = state.world.movement_get_nation_from_movement_within(m);
    if(i) {
        return issue_is_valid_for_movement(state, nation_within, i);
    }
 
    auto t = state.world.movement_get_associated_independence(m);
    if(t) {
        for(auto p : state.world.nation_get_province_ownership(nation_within)) {
            if(state.world.get_core_by_prov_tag_key(p.get_province(), t))
                return true;
        }
        return false;
    }
 
    return false;
}
 
void update_pop_movement_membership(sys::state& state) {
    state.world.for_each_pop([&](dcon::pop_id p) {
        auto owner = nations::owner_of_pop(state, p);
        // pops not in a nation can't be in a movement
        if(!owner)
            return;
 
        // - Slave pops cannot belong to a movement
        if(state.world.pop_get_poptype(p) == state.culture_definitions.slaves)
            return;
        // pops in rebel factions don't join movements
        if(state.world.pop_get_rebel_faction_from_pop_rebellion_membership(p))
            return;
 
        auto pop_location = state.world.pop_get_province_from_pop_location(p);
        // pops in colonial provinces don't join movements
        if(state.world.province_get_is_colonial(pop_location))
            return;
 
        auto existing_movement = state.world.pop_get_movement_from_pop_movement_membership(p);
        auto mil = pop_demographics::get_militancy(state, p);
 
        // -Pops with define : MIL_TO_JOIN_REBEL or greater militancy cannot join a movement
        if(mil >= state.defines.mil_to_join_rebel) {
            remove_pop_from_movement(state, p);
            return;
        }
        if(existing_movement) {
            auto i =
                    state.world.movement_get_associated_issue_option(existing_movement);
            if(i) {
                auto support = pop_demographics::get_demo(state, p, pop_demographics::to_key(state, i));
                if(support * 100.0f < state.defines.issue_movement_leave_limit) {
                    // If the pop's support of the issue for an issue-based movement drops below define:ISSUE_MOVEMENT_LEAVE_LIMIT
                    // the pop will leave the movement.
                    remove_pop_from_movement(state, p);
                    return;
                }
            } else if(mil < state.defines.nationalist_movement_mil_cap) {
                // If the pop's militancy falls below define:NATIONALIST_MOVEMENT_MIL_CAP, the pop will leave an independence
                // movement.
                remove_pop_from_movement(state, p);
                return;
            }
            // pop still remains in movement, no more work to do
            return;
        }
 
        auto con = pop_demographics::get_consciousness(state, p);
        auto lit = pop_demographics::get_literacy(state, p);
 
        // a pop with a consciousness of at least 1.5 or a literacy of at least 0.25 may join a movement
        if(con >= 1.5f || lit >= 0.25f) {
            /*
            - If there are one or more issues that the pop supports by at least define:ISSUE_MOVEMENT_JOIN_LIMIT, then the pop has
            a chance to join an issue-based movement at probability: issue-support x 9 x define:MOVEMENT_LIT_FACTOR x pop-literacy
            + issue-support x 9 x define:MOVEMENT_CON_FACTOR x pop-consciousness
            */
            dcon::issue_option_id max_option;
            float max_support = 0;
            state.world.for_each_issue_option([&](dcon::issue_option_id io) {
                auto parent = state.world.issue_option_get_parent_issue(io);
                auto co = state.world.nation_get_issues(owner, parent);
                auto allow = state.world.issue_option_get_allow(io);
                if(co != io && (state.world.issue_get_issue_type(parent) == uint8_t(culture::issue_type::social) || state.world.issue_get_issue_type(parent) == uint8_t(culture::issue_type::political))) { // filter out currently active issue
                    auto sup = pop_demographics::get_demo(state, p, pop_demographics::to_key(state, io));
                    if(sup * 100.0f >= state.defines.issue_movement_join_limit && sup > max_support) { // filter out -- above limit thersholds
                        /*
                        then the pop has a chance to join an issue-based movement at probability: issue-support x 9 x define:MOVEMENT_LIT_FACTOR x pop-literacy + issue-support x 9 x define:MOVEMENT_CON_FACTOR x pop-consciousness
                        */
 
                        // probability test
                        auto fp_prob = 9.0f * sup * (state.defines.movement_lit_factor * lit + state.defines.movement_con_factor * con);
                        auto rvalue = float(uint32_t(rng::get_random(state, (p.value << 3) ^ io.index()) & 0xFFFF)) / float(0x10000);
                        if(rvalue < fp_prob) {
 
                            // is this issue possible to get by law?
                            if(state.world.issue_get_is_next_step_only(parent) == false || co.id.index() + 1 == io.index() || co.id.index() - 1 == io.index()) {
 
                                max_option = io;
                                max_support = sup;
                            }
                        }
                    }
                }
            });
            if(max_option) {
                if(auto m = get_movement_by_position(state, owner, max_option); m) {
                    add_pop_to_movement(state, p, m);
                } else if(issue_is_valid_for_movement(state, owner, max_option)) {
                    auto new_movement = fatten(state.world, state.world.create_movement());
                    new_movement.set_associated_issue_option(max_option);
                    state.world.try_create_movement_within(new_movement, owner);
                    add_pop_to_movement(state, p, new_movement);
                }
            } else if(!state.world.pop_get_is_primary_or_accepted_culture(p) && mil >= state.defines.nationalist_movement_mil_cap) {
                /*
                - If there are no valid issues, the pop has a militancy of at least define:NATIONALIST_MOVEMENT_MIL_CAP, does not
                have the primary culture of the nation it is in, and does have the primary culture of some core in its province,
                then it has a chance (20% ?) of joining an independence movement for such a core.
                */
                if(rng::reduce(uint32_t(rng::get_random(state, p.value)), 10) != 0) {
                    return; // exit out of considering this pop
                }
                auto pop_culture = state.world.pop_get_culture(p);
                for(auto c : state.world.province_get_core(pop_location)) {
                    if(c.get_identity().get_primary_culture() == pop_culture) {
                        auto existing_mov = get_movement_by_independence(state, owner, c.get_identity());
                        if(existing_mov) {
                            state.world.try_create_pop_movement_membership(p, existing_mov);
                        } else {
                            auto new_mov = fatten(state.world, state.world.create_movement());
                            new_mov.set_associated_independence(c.get_identity());
                            state.world.try_create_movement_within(new_mov, owner);
                            state.world.try_create_pop_movement_membership(p, new_mov);
                        }
                        break;
                    }
                }
            }
        }
    });
}
 
void update_movements(sys::state& state) { // updates cached values and then possibly turns movements into rebels
    update_pop_movement_membership(state);
 
    // IMPORTANT: we count down here so that we can delete as we go, compacting from the end
    for(auto last = state.world.movement_size(); last-- > 0;) {
        dcon::movement_id m{dcon::movement_id::value_base_t(last)};
        if(!movement_is_valid(state, m)) {
            state.world.delete_movement(m);
        }
    }
 
    update_movement_values(state);
 
    for(auto last = state.world.movement_size(); last-- > 0;) {
        dcon::movement_id m{dcon::movement_id::value_base_t(last)};
        if(state.world.movement_get_radicalism(m) >= 100.0f) {
            turn_movement_into_rebels(state, m);
        }
    }
}
 
void remove_pop_from_rebel_faction(sys::state& state, dcon::pop_id p) {
    if(auto m = state.world.pop_get_pop_rebellion_membership(p); m) {
        auto fac = state.world.pop_rebellion_membership_get_rebel_faction(m);
        state.world.rebel_faction_get_possible_regiments(fac) -=
                int32_t(state.world.pop_get_size(p) / state.defines.pop_size_per_regiment);
        state.world.delete_pop_rebellion_membership(m);
    }
}
void add_pop_to_rebel_faction(sys::state& state, dcon::pop_id p, dcon::rebel_faction_id m) {
    remove_pop_from_rebel_faction(state, p);
    state.world.try_create_pop_rebellion_membership(p, m);
    state.world.rebel_faction_get_possible_regiments(m) +=
            int32_t(state.world.pop_get_size(p) / state.defines.pop_size_per_regiment);
}
 
bool rebel_faction_is_valid(sys::state& state, dcon::rebel_faction_id m) {
    /*
    - A rebel faction with no pops in it will disband
    - Rebel factions whose independence country exists will disband (different for defection rebels?)
    - Pan nationalists inside their union country will disband
    - Any pops belonging to a rebel faction that disbands have their militancy reduced to 0
    */
 
    auto pops = state.world.rebel_faction_get_pop_rebellion_membership(m);
    if(pops.begin() == pops.end())
        return false;
 
    auto type = fatten(state.world, state.world.rebel_faction_get_type(m));
 
    auto tag = state.world.rebel_faction_get_defection_target(m);
    auto within = fatten(state.world, m).get_rebellion_within().get_ruler();
    if(within.get_identity_from_identity_holder() == tag)
        return false;
 
    return true;
}
 
bool pop_is_compatible_with_rebel_faction(sys::state& state, dcon::pop_id p, dcon::rebel_faction_id t) {
    /*
    - Faction compatibility: a pop will not join a faction that it is excluded from based on its culture, culture group, religion,
    or ideology (here it is the dominant ideology of the pop that matters). There is also some logic for determining if a pop is
    compatible with a national identity for independence. I don't think it is worth trying to imitate the logic of the base game
    here. Instead I will go with: pop is not an accepted culture and either its primary culture is associated with that identity
    *or* there is no core in the province associated with its primary identity.
    */
    auto type = fatten(state.world, state.world.rebel_faction_get_type(t));
    auto fac = fatten(state.world, t);
    auto pop = fatten(state.world, p);
    if(type.get_independence() != 0 || type.get_defection() != 0) {
        if(type.get_independence() == uint8_t(culture::rebel_independence::pan_nationalist) ||
                type.get_defection() == uint8_t(culture::rebel_defection::pan_nationalist)) {
            if(pop.get_is_primary_or_accepted_culture())
                return true;
        } else {
            if(pop.get_is_primary_or_accepted_culture())
                return false;
        }
        for(auto core : pop.get_province_from_pop_location().get_core()) {
            if(core.get_identity().get_primary_culture() == pop.get_culture())
                return true;
        }
    }
    if(fac.get_primary_culture() && fac.get_primary_culture() != pop.get_culture())
        return false;
    if(fac.get_religion() && fac.get_religion() != pop.get_religion())
        return false;
    if(fac.get_primary_culture_group() &&
            fac.get_primary_culture_group() != pop.get_culture().get_group_from_culture_group_membership())
        return false;
    if(fac.get_type().get_ideology() && fac.get_type().get_ideology_restriction() && fac.get_type().get_ideology() != pop.get_dominant_ideology())
        return false;
    return true;
}
 
bool pop_is_compatible_with_rebel_type(sys::state& state, dcon::pop_id p, dcon::rebel_type_id t) {
    auto fac = fatten(state.world, t);
    auto pop = fatten(state.world, p);
 
    if(fac.get_independence() != 0 || fac.get_defection() != 0) {
        if(fac.get_independence() == uint8_t(culture::rebel_independence::pan_nationalist) ||
                fac.get_defection() == uint8_t(culture::rebel_defection::pan_nationalist)) {
            if(pop.get_is_primary_or_accepted_culture())
                return true;
        } else {
            if(pop.get_is_primary_or_accepted_culture())
                return false;
        }
        for(auto core : pop.get_province_from_pop_location().get_core()) {
            if(core.get_identity().get_primary_culture() == pop.get_culture())
                return true;
        }
        return false;
    }
    //Discriminated pops focus on independence rather than political issues
    else {
        if(!pop.get_is_primary_or_accepted_culture()) {
            return false;
        }
    }
    if(fac.get_ideology() && fac.get_ideology() != pop.get_dominant_ideology()) {
        return false;
    }
    return true;
}
 
void update_pop_rebel_membership(sys::state& state) {
    state.world.for_each_pop([&](dcon::pop_id p) {
        auto owner = nations::owner_of_pop(state, p);
        // pops not in a nation can't be in a rebel faction
        if(!owner)
            return;
 
        auto mil = pop_demographics::get_militancy(state, p);
        auto existing_faction = state.world.pop_get_rebel_faction_from_pop_rebellion_membership(p);
 
        // -Pops with define : MIL_TO_JOIN_REBEL will join a rebel_faction
        if(mil >= state.defines.mil_to_join_rebel) {
            if(existing_faction && !pop_is_compatible_with_rebel_faction(state, p, existing_faction)) {
                remove_pop_from_rebel_faction(state, p);
            } else {
                auto prov = state.world.pop_get_province_from_pop_location(p);
                /*
                - A pop in a province sieged or controlled by rebels will join that faction, if the pop is compatible with the
                faction.
                */
 
                auto occupying_faction = state.world.province_get_rebel_faction_from_province_rebel_control(prov);
                if(occupying_faction && pop_is_compatible_with_rebel_faction(state, p, occupying_faction)) {
                    assert(!bool(state.world.province_get_nation_from_province_control(prov)));
                    add_pop_to_rebel_faction(state, p, occupying_faction);
                } else {
                    /*
                    - Otherwise take all the compatible and possible rebel types. Determine the spawn chance for each of them, by
                    taking the *product* of the modifiers. The pop then joins the type with the greatest chance (that's right, it
                    isn't really a *chance* at all). If that type has a defection type, it joins the faction with the national
                    identity most compatible with it and that type (pan-nationalist go to the union tag, everyone else uses the
                    logic I outline below)
                    */
                    float greatest_chance = 0.0f;
                    dcon::rebel_faction_id f;
                    for(auto rf : state.world.nation_get_rebellion_within(owner)) {
                        if(pop_is_compatible_with_rebel_faction(state, p, rf.get_rebels())) {
                            auto chance = rf.get_rebels().get_type().get_spawn_chance();
                            auto eval = trigger::evaluate_multiplicative_modifier(state, chance, trigger::to_generic(p),
                                    trigger::to_generic(owner), trigger::to_generic(rf.get_rebels().id));
                            if(eval > greatest_chance) {
                                f = rf.get_rebels();
                                greatest_chance = eval;
                            }
                        }
                    }
 
                    dcon::rebel_faction_id temp = state.world.create_rebel_faction();
                    dcon::national_identity_id ind_tag = [&]() {
                        auto prov = state.world.pop_get_province_from_pop_location(p);
                        for(auto core : state.world.province_get_core(prov)) {
                            if(!core.get_identity().get_is_not_releasable() && core.get_identity().get_primary_culture() == state.world.pop_get_culture(p))
                                return core.get_identity().id;
                        }
                        return dcon::national_identity_id{};
                    }();
 
                    dcon::rebel_type_id max_type;
 
                    state.world.for_each_rebel_type([&](dcon::rebel_type_id rt) {
                        if(pop_is_compatible_with_rebel_type(state, p, rt)) {
                            state.world.rebel_faction_set_type(temp, rt);
                            state.world.rebel_faction_set_defection_target(temp, dcon::national_identity_id{});
                            state.world.rebel_faction_set_primary_culture(temp, dcon::culture_id{});
                            state.world.rebel_faction_set_primary_culture_group(temp, dcon::culture_group_id{});
                            state.world.rebel_faction_set_religion(temp, dcon::religion_id{});
 
                            switch(culture::rebel_defection(state.world.rebel_type_get_defection(rt))) {
                            case culture::rebel_defection::culture:
                                state.world.rebel_faction_set_primary_culture(temp, state.world.pop_get_culture(p));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_defection::culture_group:
                                state.world.rebel_faction_set_primary_culture_group(temp,
                                        state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p)));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_defection::religion:
                                state.world.rebel_faction_set_religion(temp, state.world.pop_get_religion(p));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_defection::pan_nationalist: {
                                auto cg = state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p));
                                auto u = state.world.culture_group_get_identity_from_cultural_union_of(cg);
                                if(!u)
                                    return; // skip -- no pan nationalist possible
                                state.world.rebel_faction_set_defection_target(temp, u);
                                break;
                            }
                            case culture::rebel_defection::any:
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            default:
                                break;
                            }
 
                            switch(culture::rebel_independence(state.world.rebel_type_get_independence(rt))) {
                            case culture::rebel_independence::culture:
                                state.world.rebel_faction_set_primary_culture(temp, state.world.pop_get_culture(p));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_independence::culture_group:
                                state.world.rebel_faction_set_primary_culture_group(temp,
                                        state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p)));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_independence::religion:
                                state.world.rebel_faction_set_religion(temp, state.world.pop_get_religion(p));
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_independence::pan_nationalist: {
                                auto cg = state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p));
                                auto u = state.world.culture_group_get_identity_from_cultural_union_of(cg);
                                if(!u)
                                    return; // skip -- no pan nationalist possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                state.world.rebel_faction_set_defection_target(temp, u);
                                break;
                            }
                            case culture::rebel_independence::any:
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            case culture::rebel_independence::colonial:
                                state.world.rebel_faction_set_defection_target(temp, ind_tag);
                                if(!ind_tag)
                                    return; // skip -- no defection possible
                                if(state.world.pop_get_is_primary_or_accepted_culture(p))
                                    return; // skip -- can't defect
                                break;
                            default:
                                break;
                            }
 
                            auto chance = state.world.rebel_type_get_spawn_chance(rt);
                            auto eval = trigger::evaluate_multiplicative_modifier(state, chance, trigger::to_generic(p),
                                    trigger::to_generic(owner), trigger::to_generic(temp));
                            if(eval > greatest_chance) {
                                f = temp;
                                max_type = rt;
                                greatest_chance = eval;
                            }
                        }
                    });
 
                    if(f != temp) {
                        state.world.delete_rebel_faction(temp);
                    } else {
                        auto rt = max_type;
                        state.world.rebel_faction_set_type(temp, rt);
                        state.world.rebel_faction_set_defection_target(temp, dcon::national_identity_id{});
                        state.world.rebel_faction_set_primary_culture(temp, dcon::culture_id{});
                        state.world.rebel_faction_set_primary_culture_group(temp, dcon::culture_group_id{});
                        state.world.rebel_faction_set_religion(temp, dcon::religion_id{});
 
                        switch(culture::rebel_defection(state.world.rebel_type_get_defection(rt))) {
                        case culture::rebel_defection::culture:
                            state.world.rebel_faction_set_primary_culture(temp, state.world.pop_get_culture(p));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_defection::culture_group:
                            state.world.rebel_faction_set_primary_culture_group(temp,
                                    state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p)));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_defection::religion:
                            state.world.rebel_faction_set_religion(temp, state.world.pop_get_religion(p));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_defection::pan_nationalist: {
                            auto cg = state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p));
                            auto u = state.world.culture_group_get_identity_from_cultural_union_of(cg);
                            state.world.rebel_faction_set_defection_target(temp, u);
                            break;
                        }
                        case culture::rebel_defection::any:
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        default:
                            break;
                        }
 
                        switch(culture::rebel_independence(state.world.rebel_type_get_independence(rt))) {
                        case culture::rebel_independence::culture:
                            state.world.rebel_faction_set_primary_culture(temp, state.world.pop_get_culture(p));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_independence::culture_group:
                            state.world.rebel_faction_set_primary_culture_group(temp,
                                    state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p)));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_independence::religion:
                            state.world.rebel_faction_set_religion(temp, state.world.pop_get_religion(p));
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_independence::pan_nationalist: {
                            auto cg = state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p));
                            auto u = state.world.culture_group_get_identity_from_cultural_union_of(cg);
                            state.world.rebel_faction_set_defection_target(temp, u);
                            break;
                        }
                        case culture::rebel_independence::any:
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        case culture::rebel_independence::colonial:
                            state.world.rebel_faction_set_defection_target(temp, ind_tag);
                            break;
                        default:
                            break;
                        }
 
                        if(state.world.rebel_type_get_culture_restriction(rt) && !state.world.rebel_faction_get_primary_culture(temp)) {
                            state.world.rebel_faction_set_primary_culture(temp, state.world.pop_get_culture(p));
                        }
                        if(state.world.rebel_type_get_culture_group_restriction(rt) && !state.world.rebel_faction_get_primary_culture_group(temp)) {
                            state.world.rebel_faction_set_primary_culture_group(temp, state.world.culture_get_group_from_culture_group_membership(state.world.pop_get_culture(p)));
                        }
 
                        state.world.try_create_rebellion_within(temp, owner);
                    }
 
                    if(greatest_chance > 0) {
                        add_pop_to_rebel_faction(state, p, f);
                    }
                }
            }
        } else { // less than: MIL_TO_JOIN_REBEL will join a rebel_faction -- leave faction
            if(existing_faction) {
                remove_pop_from_rebel_faction(state, p);
            }
        }
    });
}
 
void delete_faction(sys::state& state, dcon::rebel_faction_id reb) {
    auto control = state.world.rebel_faction_get_province_rebel_control(reb);
    for(auto p : control) {
        auto prov = p.get_province();
        province::set_province_controller(state, prov, prov.get_nation_from_province_ownership());
    }
    state.world.delete_rebel_faction(reb);
}
 
void update_factions(sys::state& state) {
    update_pop_rebel_membership(state);
    // IMPORTANT: we count down here so that we can delete as we go, compacting from the end
    for(auto last = state.world.rebel_faction_size(); last-- > 0;) {
        dcon::rebel_faction_id m{dcon::rebel_faction_id::value_base_t(last)};
        if(!rebel_faction_is_valid(state, m)) {
            for(auto members : state.world.rebel_faction_get_pop_rebellion_membership(m)) {
                pop_demographics::set_militancy(state, members.get_pop().id, 0.0f);
            }
            delete_faction(state, m);
        }
    }
}
 
inline constexpr float org_gain_factor = 0.4f;
 
void daily_update_rebel_organization(sys::state& state) {
    // update brigade count
    state.world.for_each_rebel_faction([&](dcon::rebel_faction_id rf) {
        int32_t total = 0;
        for(auto pop : state.world.rebel_faction_get_pop_rebellion_membership(rf)) {
            total += int32_t(state.world.pop_get_size(pop.get_pop()) / state.defines.pop_size_per_regiment);
        }
        state.world.rebel_faction_set_possible_regiments(rf, total);
    });
 
    // update org
    state.world.for_each_rebel_faction([&](dcon::rebel_faction_id rf) {
        /*
        - Sum for each pop belonging to the faction that has made money in the day: (pop-income + 0.02) x pop-literacy x (10 if
        militancy is > define:MILITANCY_TO_AUTO_RISE and 5 if militancy is less than that but > define:MILITANCY_TO_JOIN_RISING) /
        (1 + national-administration-spending-setting). Take this sum, multiply by 0.001 x (rebel organization from technology +
        1) and divide by the number of regiments those pops could form. If positive, add this to the current organization of the
        rebel faction (to a maximum of 1). This appears to be done daily.
        */
 
        float total_change = 0;
        for(auto pop : state.world.rebel_faction_get_pop_rebellion_membership(rf)) {
            auto mil_factor = [&]() {
                auto m = pop_demographics::get_militancy(state, pop.get_pop());
                if(m > state.defines.mil_to_autorise)
                    return 10.0f;
                else if(m > state.defines.mil_to_join_rising)
                    return 5.0f;
                return 1.0f;
            }();
            total_change += pop.get_pop().get_savings() * pop_demographics::get_literacy(state, pop.get_pop()) * mil_factor * org_gain_factor;
        }
        auto reg_count = state.world.rebel_faction_get_possible_regiments(rf);
        auto within = state.world.rebel_faction_get_ruler_from_rebellion_within(rf);
        auto rebel_org_mod = 1.0f + state.world.nation_get_rebel_org_modifier(within, state.world.rebel_faction_get_type(rf));
 
        if(reg_count > 0) {
            state.world.rebel_faction_set_organization(rf,
                    std::min(1.0f,
                            state.world.rebel_faction_get_organization(rf) +
                                    total_change *
                                            (1.0f + state.world.nation_get_rebel_org_modifier(within, state.world.rebel_faction_get_type(rf))) *
                                            0.001f / (1.0f + state.world.nation_get_administrative_efficiency(within)) / float(reg_count)));
        }
    });
}
 
void get_hunting_targets(sys::state& state, dcon::nation_id n, std::vector<impl::prov_str>& rebel_provs) {
    assert(rebel_provs.empty());
    auto nat = dcon::fatten(state.world, n);
    for(auto prov : nat.get_province_ownership()) {
        if(prov.get_province().get_rebel_faction_from_province_rebel_control()
            || military::rebel_army_in_province(state, prov.get_province()))
            rebel_provs.push_back(impl::prov_str{ prov.get_province().id, ai::estimate_rebel_strength(state,  prov.get_province()) });
    }
}
 
void sort_hunting_targets(sys::state& state, impl::arm_str const& ar, std::vector<impl::prov_str>& rebel_provs) {
    auto our_str = ar.str;
    auto loc = state.world.army_get_location_from_army_location(ar.a);
    std::sort(rebel_provs.begin(), rebel_provs.end(), [&](impl::prov_str const& a, impl::prov_str const& b) {
        auto aa = 0.001f * -(our_str - a.str);
        auto ab = 0.001f * -(our_str - b.str);
        auto da = province::sorting_distance(state, a.p, loc) + aa;
        auto db = province::sorting_distance(state, b.p, loc) + ab;
        if(da != db)
            return da < db;
        else
            return a.p.index() < b.p.index();
    });
}
 
void rebel_hunting_check(sys::state& state) {
    for(auto rf : state.world.in_rebel_faction) {
        auto const faction_owner = rf.get_ruler_from_rebellion_within();
        // rebel hunting logic
        if(faction_owner.get_is_player_controlled()) {
            static std::vector<impl::arm_str> rebel_hunters;
            rebel_hunters.clear();
            for(auto ar : faction_owner.get_army_control()) {
                auto loc = ar.get_army().get_location_from_army_location();
                if(ar.get_army().get_is_rebel_hunter()
                    && !ar.get_army().get_battle_from_army_battle_participation()
                    && !ar.get_army().get_navy_from_army_transport()
                    && !ar.get_army().get_arrival_time()
                    && loc.get_nation_from_province_control() == faction_owner
                    ) {
                    rebel_hunters.push_back(impl::arm_str{ ar.get_army().id, ai::estimate_army_offensive_strength (state, ar.get_army()) });
                }
            }
 
            static std::vector<impl::prov_str> rebel_provs;
            rebel_provs.clear();
            get_hunting_targets(state, faction_owner.id, rebel_provs);
 
            while(rebel_provs.size() > 0 && rebel_hunters.size() > 0) {
                auto rh = rebel_hunters[0];
                sort_hunting_targets(state, rh, rebel_provs);
 
                auto closest_prov = rebel_provs[0].p;
                std::sort(rebel_hunters.begin(), rebel_hunters.end(), [&](impl::arm_str const& a, impl::arm_str const& b) {
                    auto pa = state.world.army_get_location_from_army_location(a.a);
                    auto pb = state.world.army_get_location_from_army_location(b.a);
                    auto as = 0.001f * std::max<float>(a.str, 1.f);
                    auto bs = 0.001f * std::max<float>(b.str, 1.f);
                    auto da = province::sorting_distance(state, pa, closest_prov) + as;
                    auto db = province::sorting_distance(state, pb, closest_prov) + bs;
                    if(da != db)
                        return da < db;
                    else
                        return a.a.index() < b.a.index();
                });
 
                for(uint32_t i = 0; i < rebel_hunters.size(); ++i) {
                    auto a = rebel_hunters[i].a;
                    if(state.world.army_get_location_from_army_location(a) == closest_prov) {
                        state.world.army_get_path(a).clear();
                        state.world.army_set_arrival_time(a, sys::date{});
 
                        rebel_hunters[i] = rebel_hunters.back();
                        rebel_hunters.pop_back();
                        break;
                    } else if(auto path = province::make_land_path(state, state.world.army_get_location_from_army_location(a), closest_prov, faction_owner, a); path.size() > 0) {
                        auto existing_path = state.world.army_get_path(a);
                        auto new_size = uint32_t(path.size());
                        existing_path.resize(new_size);
                        for(uint32_t j = 0; j < new_size; j++) {
                            existing_path.at(j) = path[j];
                        }
                        state.world.army_set_arrival_time(a, military::arrival_time_to(state, a, path.back()));
                        state.world.army_set_dig_in(a, 0);
 
                        rebel_hunters[i] = rebel_hunters.back();
                        rebel_hunters.pop_back();
                        break;
                    }
                }
                rebel_provs[0] = rebel_provs.back();
                rebel_provs.pop_back();
            }
        }
    }
 
    for(const auto a : state.world.in_army) {
        if(a.get_is_rebel_hunter()
            && !a.get_battle_from_army_battle_participation()
            && !a.get_navy_from_army_transport()
            && !a.get_arrival_time()
            && a.get_location_from_army_location() != a.get_ai_province()
            && a.get_location_from_army_location().get_province_control().get_nation() == a.get_location_from_army_location().get_province_ownership().get_nation())
        {
            if(auto path = province::make_land_path(state, a.get_location_from_army_location(), a.get_ai_province(), a.get_army_control().get_controller(), a); path.size() > 0) {
                auto existing_path = state.world.army_get_path(a);
                auto new_size = uint32_t(path.size());
                existing_path.resize(new_size);
                for(uint32_t j = 0; j < new_size; j++) {
                    existing_path.at(j) = path[j];
                }
                state.world.army_set_arrival_time(a, military::arrival_time_to(state, a, path.back()));
                state.world.army_set_dig_in(a, 0);
            } else {
                state.world.army_set_ai_province(a, state.world.army_get_location_from_army_location(a));
            }
        }
    }
}
 
inline constexpr float rebel_size_reduction = 0.20f;
 
void rebel_risings_check(sys::state& state) {
    static std::vector<dcon::army_id> new_armies;
    new_armies.clear();
 
    for(auto rf : state.world.in_rebel_faction) {
        auto revolt_chance = get_faction_revolt_risk(state, rf);
        auto rval = rng::get_random(state, uint32_t(rf.id.value));
        float p_val = float(rval & 0xFFFF) / float(0x10000);
        if(p_val < revolt_chance) {
            auto const faction_owner = rf.get_ruler_from_rebellion_within();
            auto const new_to_make = int32_t(float(get_faction_brigades_ready(state, rf)) * rebel_size_reduction);
            auto counter = new_to_make;
            if(new_to_make == 0)
                continue;
 
            /*
            - When a rising happens, pops with at least define:MILITANCY_TO_JOIN_RISING will spawn faction-organization x
            max-possible-supported-regiments, to a minimum of 1 (if any more regiments are possible).
            */
            for(auto pop : rf.get_pop_rebellion_membership()) {
                if(counter == 0)
                    break;
 
                if(pop_demographics::get_militancy(state, pop.get_pop()) >= state.defines.mil_to_join_rising) {
                    auto location = pop.get_pop().get_province_from_pop_location();
 
                    // this is the logic we would use if we were creating rebel regiments
                    auto max_count = int32_t(state.world.pop_get_size(pop.get_pop()) * rebel_size_reduction / (province::is_overseas(state, pop.get_pop().get_province_from_pop_location()) ? (state.defines.pop_min_size_for_regiment_colony_multiplier * state.defines.pop_size_per_regiment) : state.defines.pop_size_per_regiment));
                    auto cregs = pop.get_pop().get_regiment_source();
                    auto used_count = int32_t(cregs.end() - cregs.begin());
 
                    if(used_count < max_count) {
                        auto pop_location = pop.get_pop().get_province_from_pop_location();
 
                        auto new_reg = military::create_new_regiment(state, dcon::nation_id{}, state.military_definitions.irregular);
                        auto a = [&]() {
                            for(auto ar : state.world.province_get_army_location(pop_location)) {
                                if(!(ar.get_army().get_battle_from_army_battle_participation()) && ar.get_army().get_controller_from_army_rebel_control() == rf)
                                    return ar.get_army().id;
                            }
                            auto new_army = fatten(state.world, state.world.create_army());
                            new_army.set_controller_from_army_rebel_control(rf);
                            new_army.set_location_from_army_location(pop_location);
                            new_armies.push_back(new_army);
                            return new_army.id;
                        }();
                        state.world.try_create_army_membership(new_reg, a);
                        state.world.try_create_regiment_source(new_reg, pop.get_pop());
 
                        --counter;
                    }
                }
            }
 
            /*
            - Faction organization is reduced to 0 after an initial rising (for later contributory risings, it may instead be reduced by
            a factor of (number-of-additional-regiments x 0.01 + 1))
            */
            rf.set_organization(0);
            if(counter != new_to_make) {
                notification::post(state, notification::message{
                    [reb = rf.id](sys::state& state, text::layout_base& contents) {
                        auto rn = rebel_name(state, reb);
                        text::add_line(state, contents, "msg_revolt_1", text::variable_type::x, std::string_view{ rn });
                        ankerl::unordered_dense::map<int32_t, int32_t> provs;
                        for(auto ar : state.world.rebel_faction_get_army_rebel_control(reb)) {
                            if(ar.get_controller() == reb) {
                                auto p = ar.get_army().get_location_from_army_location();
                                provs[p.id.index()] += 1;
                            }
                        }
                        for(auto p : provs) {
                            auto box = text::open_layout_box(contents, 15);
                            text::add_to_layout_box(state, contents, box, dcon::province_id(dcon::province_id::value_base_t(p.first)));
                            text::add_to_layout_box(state, contents, box, std::string_view(" ("));
                            text::add_to_layout_box(state, contents, box, text::int_wholenum{ p.second });
                            text::add_to_layout_box(state, contents, box, std::string_view(")"));
                            text::close_layout_box(contents, box);
                        }
                    },
                    "msg_revolt_title",
                    rf.get_ruler_from_rebellion_within(), dcon::nation_id{}, dcon::nation_id{},
                    sys::message_base_type::revolt });
            }
        }
    }
 
    for(auto a : new_armies) {
        if(!state.world.army_get_battle_from_army_battle_participation(a))
            military::army_arrives_in_province(state, a, state.world.army_get_location_from_army_location(a), military::crossing_type::none);
    }
}
 
bool sphere_member_has_ongoing_revolt(sys::state& state, dcon::nation_id n) {
    auto nation_count = state.world.nation_size();
    for(uint32_t i = 0; i < nation_count; ++i) {
        dcon::nation_id m{dcon::nation_id::value_base_t(i)};
        if(state.world.nation_get_in_sphere_of(m) == n) {
            for(auto fac : state.world.nation_get_rebellion_within(m)) {
                if(get_faction_brigades_active(state, fac.get_rebels()) > 0)
                    return true;
            }
        }
    }
    return false;
}
 
int32_t get_faction_brigades_ready(sys::state& state, dcon::rebel_faction_id r) {
    return state.world.rebel_faction_get_possible_regiments(r) - get_faction_brigades_active(state, r);
}
 
int32_t get_faction_brigades_active(sys::state& state, dcon::rebel_faction_id r) {
    int32_t total = 0;
    for(auto ar : state.world.rebel_faction_get_army_rebel_control(r)) {
        auto regs = ar.get_army().get_army_membership();
        total += int32_t(regs.end() - regs.begin());
    }
    return total;
}
 
float get_faction_organization(sys::state& state, dcon::rebel_faction_id r) {
    return state.world.rebel_faction_get_organization(r);
}
 
float get_faction_revolt_risk(sys::state& state, dcon::rebel_faction_id r) {
    /*
    - Rebels have a chance to rise once per month. The probability the rising will happen is: faction-organization x 0.05 + 0.02 +
    faction-organization x number-of-regiments-the-rising-could-form / 1v(number-of-regiments-controlled-by-nation x 20)
    */
    auto nation_brigades =
            std::max(1, int32_t(state.world.nation_get_active_regiments(state.world.rebel_faction_get_ruler_from_rebellion_within(r))));
 
    auto num_brigades_ready = get_faction_brigades_ready(state, r);
    auto faction_org = state.world.rebel_faction_get_organization(r);
 
    if(num_brigades_ready <= 0) {
        return 0.0f;
    }
 
    float chance = std::clamp(
            faction_org * 0.05f + 0.02f + faction_org * float(num_brigades_ready) / (float(nation_brigades) * 20.0f), 0.0f, 1.0f);
    return chance;
}
 
void execute_province_defections(sys::state& state) {
    province::for_each_land_province(state, [&](dcon::province_id p) {
        auto reb_controller = state.world.province_get_rebel_faction_from_province_rebel_control(p);
        auto owner = state.world.province_get_nation_from_province_ownership(p);
        if(reb_controller && owner) {
            assert(!bool(state.world.province_get_nation_from_province_control(p)));
            auto reb_type = state.world.rebel_faction_get_type(reb_controller);
            culture::rebel_defection def_type = culture::rebel_defection(reb_type.get_defection());
            if(def_type != culture::rebel_defection::none && state.world.province_get_last_control_change(p) + reb_type.get_defect_delay() * 31 <= state.current_date) {
                // defection time
 
                dcon::nation_id defection_tag = [&]() {
                    switch(def_type) {
                    case culture::rebel_defection::ideology: {
                        // prefer existing tag of same ideology
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(holder.get_ruling_party().get_ideology() == reb_type.get_ideology() && holder.get_owned_province_count() != 0) {
                                return c.get_identity().get_nation_from_identity_holder().id;
                            }
                        }
                        // otherwise pick a non-existent tag
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(!c.get_identity().get_is_not_releasable() && holder.get_owned_province_count() == 0) {
                                auto t = c.get_identity().get_nation_from_identity_holder().id;
                                nations::create_nation_based_on_template(state, t, owner);
                                politics::force_nation_ideology(state, t, reb_type.get_ideology());
                                return t;
                            }
                        }
                        break;
                    }
                    case culture::rebel_defection::religion:
                        // prefer existing
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(holder.get_religion() == state.world.rebel_faction_get_religion(reb_controller) && holder.get_owned_province_count() != 0) {
                                return c.get_identity().get_nation_from_identity_holder().id;
                            }
                        }
                        // otherwise pick a non-existent tag
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(!c.get_identity().get_is_not_releasable() && c.get_identity().get_religion() == state.world.rebel_faction_get_religion(reb_controller) && holder.get_owned_province_count() == 0) {
                                auto t = c.get_identity().get_nation_from_identity_holder().id;
                                nations::create_nation_based_on_template(state, t, owner);
                                return t;
                            }
                        }
                        break;
                    case culture::rebel_defection::culture:
                        // prefer existing
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(c.get_identity().get_primary_culture() == state.world.rebel_faction_get_primary_culture(reb_controller) && holder.get_owned_province_count() != 0) {
                                return c.get_identity().get_nation_from_identity_holder().id;
                            }
                        }
                        // otherwise pick a non-existent tag
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(!c.get_identity().get_is_not_releasable() && c.get_identity().get_primary_culture() == state.world.rebel_faction_get_primary_culture(reb_controller) && holder.get_owned_province_count() == 0) {
                                auto t = c.get_identity().get_nation_from_identity_holder().id;
                                nations::create_nation_based_on_template(state, t, owner);
                                return t;
                            }
                        }
                        break;
                    case culture::rebel_defection::culture_group:
                        // prefer existing
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(c.get_identity().get_primary_culture().get_group_from_culture_group_membership() == state.world.rebel_faction_get_primary_culture_group(reb_controller) && holder.get_owned_province_count() != 0) {
                                return c.get_identity().get_nation_from_identity_holder().id;
                            }
                        }
                        // otherwise pick a non-existent tag
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(!c.get_identity().get_is_not_releasable()
                                && c.get_identity().get_primary_culture().get_group_from_culture_group_membership() == state.world.rebel_faction_get_primary_culture_group(reb_controller)
                                && holder.get_owned_province_count() == 0) {
 
                                auto t = c.get_identity().get_nation_from_identity_holder().id;
                                nations::create_nation_based_on_template(state, t, owner);
                                return t;
                            }
                        }
 
                        // first: existing tag of culture; then existing tag of culture group;
                        // then dead tag of culture, then dead tag of cg
                        break;
                    case culture::rebel_defection::pan_nationalist:
                        // union tag or nothing
                        for(auto c : state.world.province_get_core(p)) {
                            auto holder = c.get_identity().get_nation_from_identity_holder();
                            if(c.get_identity() == state.world.rebel_faction_get_defection_target(reb_controller) && holder.get_owned_province_count() != 0) {
                                return holder.id;
                            }
                        }
                        break;
                    default: // NONE and ANY
                        return dcon::nation_id{};
                    }
                    return dcon::nation_id{};
                }();
 
                if(defection_tag) {
                    // TODO: if rebel armies were still a thing, you would probably want to delete the ones that did
                    // the work of causing the province to defect or to send them back to the original country or something
                    // but ...
                    province::change_province_owner(state, p, defection_tag);
                }
            }
        }
    });
}
 
float get_suppression_point_cost(sys::state& state, dcon::movement_id m) {
    /*
    Depends on whether define:POPULATION_SUPPRESSION_FACTOR is non zero. If it is zero, suppression costs their effective
    radicalism + 1. If it is non zero, then the cost is the greater of that value and the movements effective radicalism x the
    movement's support / define:POPULATION_SUPPRESSION_FACTOR
    */
    if(state.defines.population_suppression_factor > 0.0f) {
        return std::max(state.world.movement_get_radicalism(m) + 1.0f, state.world.movement_get_radicalism(m) *
            state.world.movement_get_pop_support(m) / state.defines.population_suppression_factor);
    } else {
        return state.world.movement_get_radicalism(m) + 1.0f;
    }
}
 
void execute_rebel_victories(sys::state& state) {
    for(uint32_t i = state.world.rebel_faction_size(); i-- > 0;) {
        auto reb = dcon::rebel_faction_id{dcon::rebel_faction_id::value_base_t(i)};
        auto within = state.world.rebel_faction_get_ruler_from_rebellion_within(reb);
        auto is_active = get_faction_brigades_active(state, reb) > 0;
        auto enforce_trigger = state.world.rebel_faction_get_type(reb).get_demands_enforced_trigger();
        if(is_active && enforce_trigger &&
                trigger::evaluate(state, enforce_trigger, trigger::to_generic(within), trigger::to_generic(within),
                        trigger::to_generic(reb))) {
            // rebel victory
 
            /*
            The government type of the nation will change if the rebel type has an associated government (with the same logic for
            a government type change from a wargoal or other cause).
            */
 
            auto old_gov = state.world.nation_get_government_type(within);
            assert(old_gov);
            auto new_gov = state.world.rebel_faction_get_type(reb).get_government_change(old_gov);
            if(new_gov) {
                politics::change_government_type(state, within, new_gov);
            }
            if(auto iid = state.world.rebel_faction_get_type(reb).get_ideology(); iid) {
                politics::force_nation_ideology(state, within, iid);
            }
            //The pops won, reset their militancy to avoid death spiraling
            for(auto members : state.world.rebel_faction_get_pop_rebellion_membership(reb)) {
                pop_demographics::set_militancy(state, members.get_pop().id, std::max(pop_demographics::get_militancy(state, members.get_pop()) - 8.0f, 0.0f));
            }
 
            /*
            If the rebel type has "break alliances on win" then the nation loses all of its alliances, all of its non-substate
            vassals, all of its sphere members, and loses all of its influence and has its influence level set to neutral.
            */
 
            if(state.world.rebel_faction_get_type(reb).get_break_alliance_on_win()) {
                nations::destroy_diplomatic_relationships(state, within);
            }
 
            /*
            The nation loses prestige equal to define:PRESTIGE_HIT_ON_BREAK_COUNTRY x (nation's current prestige + permanent
            prestige), which is multiplied by the nation's prestige modifier from technology + 1 as usual (!).
            */
            auto ploss = state.defines.prestige_hit_on_break_country * nations::prestige_score(state, within);
            nations::adjust_prestige(state, within, ploss);
 
 
            /*
            If it wins, it gets its `demands_enforced_effect` executed.
            */
 
            if(auto k = state.world.rebel_faction_get_type(reb).get_demands_enforced_effect(); k)
                effect::execute(state, k, trigger::to_generic(within), trigger::to_generic(within), trigger::to_generic(reb),
                        uint32_t(state.current_date.value), uint32_t(within.index() ^ (reb.index() << 4)));
 
            notification::post(state, notification::message{
                [type = state.world.rebel_faction_get_type(reb).id, ploss, new_gov, within, when = state.current_date, i = reb.index()](sys::state& state, text::layout_base& contents) {
 
                    text::add_line(state, contents, "msg_rebels_win_1", text::variable_type::x, state.world.rebel_type_get_title(type));
                    text::add_line(state, contents, "msg_rebels_win_2", text::variable_type::x, text::fp_one_place{ploss});
                    if(new_gov) {
                        text::add_line(state, contents, "msg_rebels_win_3", text::variable_type::x, state.world.government_type_get_name(new_gov));
                    }
                    if(auto iid = state.world.rebel_type_get_ideology(type); iid) {
                        text::add_line(state, contents, "msg_rebels_win_4", text::variable_type::x, state.world.ideology_get_name(iid));
                    }
                    if(state.world.rebel_type_get_break_alliance_on_win(type)) {
                        text::add_line(state, contents, "msg_rebels_win_5");
                    }
                    if(auto k = state.world.rebel_type_get_demands_enforced_effect(type); k) {
                        text::add_line(state, contents, "msg_rebels_win_6");
                        ui::effect_description(state, contents, k, trigger::to_generic(within), trigger::to_generic(within), -1, uint32_t(when.value), uint32_t(within.index() ^ (i << 4)));
                    }
                },
                "msg_rebels_win_title",
                within, dcon::nation_id{}, dcon::nation_id{},
                sys::message_base_type::breakcountry
            });
 
            /*
            Any units for the faction that exist are destroyed (or transferred if it is one of the special rebel types).
            */
            delete_faction(state, reb);
        }
    }
}
 
void trigger_revolt(sys::state& state, dcon::nation_id n, dcon::rebel_type_id t, dcon::ideology_id i, dcon::culture_id c,
        dcon::religion_id r) {
    // TODO
}
 
std::string rebel_name(sys::state& state, dcon::rebel_faction_id reb) {
    text::substitution_map sub;
 
    auto culture = state.world.rebel_faction_get_primary_culture(reb);
    auto religion = state.world.rebel_faction_get_religion(reb);
    auto defection_target = state.world.rebel_faction_get_defection_target(reb);
    auto in_nation = state.world.rebel_faction_get_ruler_from_rebellion_within(reb);
    auto rebel_adj = text::get_adjective(state, in_nation);
    auto adjective = defection_target.get_adjective();
 
    text::add_to_substitution_map(sub, text::variable_type::country, rebel_adj);
    text::add_to_substitution_map(sub, text::variable_type::country_adj, rebel_adj);
 
    if(culture) {
        text::add_to_substitution_map(sub, text::variable_type::culture, culture.get_name());
    } else {
        text::add_to_substitution_map(sub, text::variable_type::culture, state.world.nation_get_primary_culture(in_nation).get_name());
    }
 
    if(religion) {
        text::add_to_substitution_map(sub, text::variable_type::religion, religion.get_name());
    }
 
    if(defection_target) {
        text::add_to_substitution_map(sub, text::variable_type::indep, adjective);
        text::add_to_substitution_map(sub, text::variable_type::union_adj, adjective);
    } else {
        text::add_to_substitution_map(sub, text::variable_type::union_adj, state.world.nation_get_primary_culture(in_nation).get_group_from_culture_group_membership().get_identity_from_cultural_union_of().get_adjective());
    }
 
    return text::resolve_string_substitution(state, state.world.rebel_faction_get_type(reb).get_name(), sub);
}
 
bool allow_in_area(sys::state& state, dcon::province_id p, dcon::rebel_faction_id reb) {
    auto rf = dcon::fatten(state.world, reb);
    auto prov = dcon::fatten(state.world, p);
    switch(culture::rebel_area(rf.get_type().get_area())) {
    case culture::rebel_area::all:
        return true;
    case culture::rebel_area::culture:
        return prov.get_dominant_culture() == rf.get_primary_culture();
    case culture::rebel_area::culture_group:
        return prov.get_dominant_culture().get_culture_group_membership().get_group() == rf.get_primary_culture_group();
    case culture::rebel_area::religion:
        return prov.get_dominant_religion() == rf.get_religion();
    case culture::rebel_area::nation_religion:
        return prov.get_dominant_religion() == rf.get_defection_target().get_religion() && prov.get_province_ownership().get_nation() == rf.get_rebellion_within().get_ruler();
    case culture::rebel_area::nation_culture:
        return prov.get_dominant_culture() == rf.get_defection_target().get_primary_culture() && prov.get_province_ownership().get_nation() == rf.get_rebellion_within().get_ruler();
    case culture::rebel_area::nation:
        return prov.get_province_ownership().get_nation() == rf.get_rebellion_within().get_ruler();
    default:
        break;
    }
    return false;
}
 
void update_armies(sys::state& state) {
    concurrency::parallel_for(uint32_t(0), state.world.army_rebel_control_size(), [&](uint32_t i) {
        auto ar_reb_control = dcon::army_rebel_control_id{ dcon::army_rebel_control_id::value_base_t(i) };
        if(!state.world.army_rebel_control_is_valid(ar_reb_control))
            return;
        auto arc = dcon::fatten(state.world, ar_reb_control);
        auto ar = arc.get_army();
        if(!ar.get_army_rebel_control().get_controller()) /* Not a rebel army */
            return;
        if(ar.get_arrival_time() != sys::date{}) /* Do not interrupt travel */
            return;
        if(ar.get_battle_from_army_battle_participation()) /* In battle */
            return;
        if(ar.get_navy_from_army_transport()) /* Or in naval transport... */
            return;
 
        auto type = arc.get_controller().get_type();
        auto area = arc.get_controller().get_type().get_area();
        auto location = ar.get_location_from_army_location();
        /* If on an unsieged province, siege it! */
        if(location.get_nation_from_province_control() && !location.get_rebel_faction_from_province_rebel_control()) {
            return;
        }
        dcon::province_fat_id best_prov = location;
        float best_weight = 0.f;// trigger::evaluate_multiplicative_modifier(state, type.get_movement_evaluation(), trigger::to_generic(best_prov), trigger::to_generic(best_prov), 0);;
        for(const auto adj : location.get_province_adjacency()) {
            auto indx = adj.get_connected_provinces(0) != location.id ? 0 : 1;
            auto prov = adj.get_connected_provinces(indx);
            /* sea province */
            if(prov.id.index() >= state.province_definitions.first_sea_province.index())
                continue;
            /* impassable */
            if((adj.get_type() & province::border::impassible_bit) != 0)
                continue;
            if(allow_in_area(state, prov, arc.get_controller())) {
                //float weight = trigger::evaluate_multiplicative_modifier(state, type.get_movement_evaluation(), trigger::to_generic(prov), trigger::to_generic(prov), trigger::to_generic(arc.get_controller()));
                float weight = float(rng::get_random(state, uint32_t(prov.id.index() * ar.id.index())) % 100);
                //if(prov.get_army_location().begin() != prov.get_army_location().end()) {
                //  weight *= 0.01f;
                //}
                if(prov.get_rebel_faction_from_province_rebel_control()) {
                    weight *= 0.0001f;
                }
                if(weight >= best_weight) {
                    best_weight = weight;
                    best_prov = prov;
                }
            }
        }
        if(best_prov != location) {
            ar.get_path().resize(1);
            ar.get_path()[0] = best_prov;
            ar.set_arrival_time(military::arrival_time_to(state, ar.id, best_prov));
            ar.set_dig_in(0);
            ar.set_is_rebel_hunter(false);
        }
    });
}
 
} // namespace rebel